Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add delegate option to cors middleware #3613

Merged
merged 3 commits into from
Jan 31, 2020
Merged

feature: Add delegate option to cors middleware #3613

merged 3 commits into from
Jan 31, 2020

Conversation

michieldewilde
Copy link
Contributor

This adds the option to configure cors asynchronously #3612.

@apollo-cla
Copy link

@michieldewilde: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@abernix abernix added this to the Release 2.10.0 milestone Jan 31, 2020
abernix
abernix approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abernix abernix merged commit 53f9021 into apollographql:master Jan 31, 2020
@michieldewilde michieldewilde deleted the feature/add-cors-options-deletegate branch September 22, 2020 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abernix abernix abernix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michieldewilde @apollo-cla @abernix