Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-functions: Send CORS headers on OPTIONS requests. #3557

Merged
merged 5 commits into from
Dec 18, 2019

Conversation

dadvir
Copy link
Contributor

@dadvir dadvir commented Nov 25, 2019

Headers are not sent to the client. Moved the response set command a few lines ahead.

Headers are not sent to the client. Moved the response set command a few lines ahead.
@apollo-cla
Copy link

@dadvir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@dadvir
Copy link
Contributor Author

dadvir commented Nov 25, 2019

I get a message that Your tests failed on CircleCI and it's an authentication issue. Anyone can help? @apollo-cla

@abernix abernix changed the title Fix a CORS issue cloud-functions: Send CORS headers on OPTIONS requests. Dec 18, 2019
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abernix abernix merged commit f5a8722 into apollographql:master Dec 18, 2019
@abernix abernix added this to the Release 2.9.15 milestone Dec 18, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants