-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] - Fastify Deprecated Warning #3527
[FIX] - Fastify Deprecated Warning #3527
Conversation
@pauloedurezende: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
these sorts of holdups are silly. @pauloedurezende can you merge in the latest commits, so your branch is up to date? |
Duplicate of #2391 |
Closing as duplicate of #3527 and #2391. It is absolutely on my mind to get the major version bumped in the next major version of Apollo Server. I understand the disappointing delay, in particular on the Fastify updates, but opening more of these same/similar PRs won't get the blockers unblocked for that work. We are trying to get to a stage where this is less problematic both now, and in the future. (See also, #3184 and #3576) |
fastify
andprotobufjs
packagespreHandler
insteadbeforeHandlers
- Fix Issue apollo-server-fastify warningbeforeHandler
has been deprecated #3477