Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - Fastify Deprecated Warning #3527

Conversation

pauloedurezende
Copy link
Contributor

@apollo-cla
Copy link

@pauloedurezende: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

@bkulyk bkulyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dfee
Copy link

dfee commented Mar 1, 2020

these sorts of holdups are silly.

@pauloedurezende can you merge in the latest commits, so your branch is up to date?
@abernix you were the last committer and an authorized merger. can you take a look and get this merged?

@markrzen
Copy link

Duplicate of #2391

@abernix
Copy link
Member

abernix commented Apr 22, 2020

Closing as duplicate of #3527 and #2391. It is absolutely on my mind to get the major version bumped in the next major version of Apollo Server. I understand the disappointing delay, in particular on the Fastify updates, but opening more of these same/similar PRs won't get the blockers unblocked for that work. We are trying to get to a stage where this is less problematic both now, and in the future. (See also, #3184 and #3576)

@abernix abernix closed this Apr 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants