Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty definition for Subscription when composing the schema #3358

Conversation

jsangilve
Copy link

Adds an Empty Definition for Subscription type, the same way it's already done for Query and Mutation.

Solves #3357

@apollo-cla
Copy link

@jsangilve: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

abernix
abernix previously approved these changes Sep 30, 2019
@abernix abernix requested a review from jbaxleyiii September 30, 2019 16:16
@jsangilve
Copy link
Author

Can you folks finish the review of this? It's breaks the Gateway when one of the federated services have subscriptions.

@jsangilve jsangilve closed this Oct 2, 2019
@jsangilve jsangilve reopened this Oct 2, 2019
@abernix abernix dismissed their stale review October 2, 2019 09:20

Needs tests.

@abernix
Copy link
Member

abernix commented Oct 2, 2019

@jsangilve Do you mind adding some tests for this using the original reproduction you opened in #3357?

Please understand that we have other priorities as well and there are a lot of other things in motion and I'm not the only person who has to review and think about this. Thanks!

@abernix
Copy link
Member

abernix commented Oct 3, 2019

I appreciate that you're exploring this but, upon further consideration, let's re-open this after we've discussed the use cases here a bit more in the issue that you opened. I'll comment over there.

@abernix abernix closed this Oct 3, 2019
@ColorBuffer
Copy link

Hi,
I also need this feature as a quick fix to have subscriptions in a "single API".

thanks for taking the time to review.

@cletustboone
Copy link

Is forking the only option here? I am running up against this issue as well.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants