Allow to use @provide with interfaces

[vitramir]

Solution for this issue https://github.com/apollographql/apollo-server/issues/3231

[apollo-cla]

@vitramir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[trevor-scheer]

Hey @vitramir, thanks for taking the time to put this together! This change makes sense to me, and I don't have any comments to add on the implementation 👍

Would you mind adding a few tests that demonstrate the new functionality?
We'd also appreciate a changelog entry in apollo-federation/CHANGELOG.md 😄

Thanks again!

[vitramir]

Ok, I will add some tests

[vitramir]

@trevor-scheer I added the test you requested

[trevor-scheer]

Thanks @vitramir, apologies for the delay on this. Your test does show composition adding the metadata as expected, but we'd like to see an integration test case that covers this as well.

A great spot for a test like this would be here:
https://github.com/apollographql/apollo-server/blob/master/packages/apollo-gateway/src/__tests__/integration/provides.test.ts

If you have any questions, please let me know. Thanks!

[trevor-scheer]

Closing this was a mistake, I targeted the wrong PR. Reopening this one.

[ksaldana1]

@vitramir @trevor-scheer Any update on this particular PR? I know a whole bunch of other interface issues got solved with #3529, but I still feel like I see issues around the interaction of provides + interfaces.

[vitramir]

@trevor-scheer I have just read through the thread and understand that I have to add tests. Is it actual task?

[vitramir]

@trevor-scheer I have added integration tests

[jgnieuwhof]

@vitramir / @trevor-scheer - any updates here? We've got a team here experiencing some pain trying to use interfaces across services in our federated graph; being able to specify @provides on a field that returns an interface should allow us to properly route field requests to the appropriate service(s).

This comment from @martijnwalraven suggests that support is intended: #2987 (comment).

As per apollographql/federation#141, this PR would need to be re-created in the new repo, aside from that are there any real blockers to moving this forward?

If there's anything I can do to help I'd be happy to do so.

[abernix]

Hi @vitramir!,

This is a semi-automated message. Apologies for the lack of personal detail. I’d encourage reading the rest of this message but, if you're busy, hopefully this is as easy for you — or someone who is willing to own the contribution — as pushing the button later in this message to re-create this PR, from an auto-migrated branch, on the new Federation repository. If you have time, read on!

We’re in the process of moving federation-related concerns out of this repository (where it has historically lived) into a new home specifically for Apollo Federation. This PR is affected by the transition since it touches code which has been moved.

I’ve done some preparations to make this as easy as possible, but we’ll need to close this PR, and I could use your help in re-opening it on the new Apollo Federation repository.

In apollographql/federation#134 (which has a lot more details, if you’re interested), we introduced the same code that was in this repository to the new Federation repository (maintaining its history) and removed the code from this repository in #4561.

While this PR still needs to get reviewed and approved to land, it should no longer live in this repository in its current state since it cannot merge in anymore. To facilitate the movement of this PR to the new home, I’ve automatically generated branches on the new repository using the same commit authorship and messages that you originally included on this PR.

Pull-requests can’t be moved on GitHub in the same way Issues can be. While I could just create the PRs from these new branches too, the contribution belongs to you!

---

Original PR author only: Click this button to open a new PR from the auto-created apollo-server-import/pr-3244 branch on the new Apollo Federation repository

(The code and your commits should be the same and you will have an opportunity to confirm, but this way you can continue to be the author and track its progress on the new Federation repository!)

---

There’s no easy way to bring over any existing comments on this PR, so I encourage you to copy and paste those onto the new issue if possible.

Overall, I hope this process is relatively easy for you while maintaining your commit contribution authorship. I apologize for any inconvenience caused by this shuffle, but please ping me if I can help in any way!

🚀