Edits from @StephenBarlow to "Plugins" article #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenBarlow
added
📝 documentation
abernix
reviewed
Aug 26, 2019
There was a problem hiding this comment.
@StephenBarlow I love your edits! Feel free to change the target branch of this PR to the branch of my PR (#2008). We can merge from here to there and there to (eventually; soon-ish) master.
|
@abernix Done! The PR now includes a boatload of commits because I rebased on a pretty recent master 😬 |
StephenBarlow
force-pushed
the
sb/plugins-edits
branch
from
b6dc4b2
to
ae36506
Compare
StephenBarlow
force-pushed
the
sb/plugins-edits
branch
from
ae36506
to
7c6cad0
Compare
|
Linking this to #2008. |
abernix
force-pushed
the
sb/plugins-edits
branch
from
e2f5c33
to
988c759
Compare
abernix
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abernix Would love your feedback on this rewrite-in-progress! So far I'm down to line 205; everything below that still needs editing and/or reorganizing.
Once we get this into a totally-good state, I can either reopen it against your open PR or we can replace it with this one wholesale.