-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose TypeScript types for apollo-server-testing client #2871
Conversation
@schmod: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
I'm going to need to run this CLA by some folks. Would the Apollo folks mind adding this to the documentation and contributor guides? This is one of the stronger CLAs that I've seen, and it's a little awkward being blindsided by it after submitting a Pull Request, as there are definitely folks who aren't going to be able to sign it. |
CLA signed! |
Per the suggestion from @schmod in #2871 (comment), this adds a note that contributors will be expected to sign a Contributor License Agreement (CLA) when contributing to the Apollo Server project.
Sorry for the blindside! As it notes at the bottom of the agreement (which I know you couldn't have known about ahead of time!), our CLA is derived from the Apache Software Foundation's Individual Contributor License Agreement V2.0. The specific deviations from the original are also itemized there. That said, I've added a note to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@abernix Thanks!!! I appreciate the update! |
This is a small Pull Request to expose a TypeScript type for the test clients that can be created with the
apollo-server-testing
client.