Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use express response methods #2842

Merged
merged 4 commits into from
Jul 28, 2019
Merged

Use express response methods #2842

merged 4 commits into from
Jul 28, 2019

Commits on Jun 14, 2019

  1. Use express response methods 

    We should not bypass the express conventions here. Doing so prevents other middleware from working as intended.

This includes `graphql-upload`, which is currently unable to force the response to wait for the request to be fully consumed, and causes severe bugs, including locking a browser out of subsequent requests to the server.

See:
jaydenseric/graphql-upload#152 (comment)
    @mike-marcacci
    mike-marcacci authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    1c959d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2019

  1. Use Express' send method when available, but fallback to Node's end.

    @abernix
    abernix committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    e6d0976 View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG.md for apollographql#2842.

    @abernix
    abernix committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    d788c96 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into HEAD

    @abernix
    abernix committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    5b66717 View commit details
    Browse the repository at this point in the history