Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.1 #2754

Merged
merged 5 commits into from
May 31, 2019
Merged

Release 2.6.1 #2754

merged 5 commits into from
May 31, 2019

Conversation

abernix
Copy link
Member

@abernix abernix commented May 31, 2019

This reverts an unintended breaking change in Apollo Server 2.6.1 which caused
typeDefs which were defined as a string rather than a DocumentNode (i.e.
wrapped in the gql template tagged literal) to result in an error within the
new isDirectiveDefined functionality.

This was reported in #2753.

TypeScript users would have been guarded against using typeDefs as a string,
but in JavaScript, there is no such protection and typeDefs historically have
frequently string-typed because of the internal graphql-tools usage which
supported this pattern.

And in case any readers of this didn't know, while many will wrap their
typeDefs in the gql tag hoping to gain syntax-highlighing in their editor
(a very good reason!), it does also do more — like parse its body into a
DocumentNode!

6adec0ad (Jesse Rosenberger, 9 minutes ago)
   Add CHANGELOG.md for breaking change inadvertently introduced in 2.6.0.

   Also added the MISSING `CHANGELOG.md` from the original release which I 
   somehow stomped out!

   Ref: #2428

c742335a (Jesse Rosenberger, 13 minutes ago)
   Revert "Avoid duplicate `cacheControl` directives via `isDirectiveDefined`
   (#2428)"

   This reverts commit 4e84defd23112ef19f502193105a7597bc6886be.

Also added the MISSING `CHANGELOG.md` from the original release which I
somehow stomped out!

Ref: #2428
Empty commit to let Lerna know that _something_ has changed, even if it is
just the version that I'm _about_ to input and it doesn't know about yet!
@abernix
Copy link
Member Author

abernix commented May 31, 2019

Big thank you to @trevor-scheer for helping to track down the cause of this!

@abernix abernix merged commit dab8506 into master May 31, 2019
@trevor-scheer trevor-scheer deleted the release-2.6.1 branch May 31, 2019 23:30
@trevor-scheer trevor-scheer restored the release-2.6.1 branch May 31, 2019 23:31
@wKovacs64
Copy link

Hmm, did the 2.6.1 release go sideways? Can't seem to install even though npm shows the 2.6.1 version exists. Tried a few of the packages listed (e.g. [email protected], [email protected], etc.). Yarn prompts to select a version and npm says the following:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for [email protected]
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

@fullstackwebdev
Copy link

This broke my CICD server

yarn install v1.15.2
info No lockfile found.
[1/4] Resolving packages...
error Couldn't find any versions for "apollo-server-express" that matches "2.6.1"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

ERROR: for backend  (<Service: backend>, "The command '/bin/sh -c npx yarn' returned a non-zero code: 1")
Service 'backend' failed to build: The command '/bin/sh -c npx yarn' returned a non-zero code: 1
ERROR: Job failed: exit code 1

@trevor-scheer
Copy link
Member

@wKovacs64 @fullstackwebdev can either of you still reproduce the issue? I was seeing it for a few minutes, but it seems to have cleared up for me. Seems like some funny CDN business.

@wKovacs64
Copy link

Agreed, seems fine now. Weird.

@abernix abernix added the 📦 release Applied to PRs which track upcoming releases. label Feb 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📦 release Applied to PRs which track upcoming releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants