-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.6.1 #2754
Release 2.6.1 #2754
Conversation
Also added the MISSING `CHANGELOG.md` from the original release which I somehow stomped out! Ref: #2428
- [email protected] - @apollo/[email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
Empty commit to let Lerna know that _something_ has changed, even if it is just the version that I'm _about_ to input and it doesn't know about yet!
- [email protected] - [email protected] - @apollo/[email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
|
Big thank you to @trevor-scheer for helping to track down the cause of this! |
Hmm, did the 2.6.1 release go sideways? Can't seem to install even though npm shows the 2.6.1 version exists. Tried a few of the packages listed (e.g.
|
This broke my CICD server
|
@wKovacs64 @fullstackwebdev can either of you still reproduce the issue? I was seeing it for a few minutes, but it seems to have cleared up for me. Seems like some funny CDN business. |
Agreed, seems fine now. Weird. |
This reverts an unintended breaking change in Apollo Server 2.6.1 which caused
typeDefs
which were defined as astring
rather than aDocumentNode
(i.e.wrapped in the
gql
template tagged literal) to result in an error within thenew
isDirectiveDefined
functionality.This was reported in #2753.
TypeScript users would have been guarded against using
typeDefs
as a string,but in JavaScript, there is no such protection and
typeDefs
historically havefrequently
string
-typed because of the internalgraphql-tools
usage whichsupported this pattern.
And in case any readers of this didn't know, while many will wrap their
typeDefs
in thegql
tag hoping to gain syntax-highlighing in their editor(a very good reason!), it does also do more — like parse its body into a
DocumentNode
!