Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-server-testing] add complete typing for ...rest args #2307

Merged
merged 5 commits into from
Apr 25, 2019
Merged

[apollo-server-testing] add complete typing for ...rest args #2307

merged 5 commits into from
Apr 25, 2019

Conversation

feinoujc
Copy link
Contributor

@feinoujc feinoujc commented Feb 12, 2019 •
edited
Loading

fixes #2172

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@feinoujc: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix abernix merged commit 0609aca into apollographql:master Apr 25, 2019
@abernix abernix mentioned this pull request Apr 30, 2019
Closed
4 tasks
@borekb borekb mentioned this pull request Jun 5, 2019
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abernix abernix abernix approved these changes

@martijnwalraven martijnwalraven Awaiting requested review from martijnwalraven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apollo-server-testing createTestClient types
3 participants
@feinoujc @apollo-cla @abernix