-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AER: include encodedTraces
only once to prevent duplicates
#2040
Merged
Commits on Nov 29, 2018
-
AER: Remove encodedTraces to prevent duplicates
When there are multiple instances of apollo-engine-reporting, the `Trace.encode` method gets wrapped each time to add the `encodedTraces`. In order to prevent them from being added to the protobuf multiple times, we remove the encodedTraces after adding them once
Configuration menu - View commit details
-
Copy full SHA for 5f9f86b - Browse repository at this point
Copy the full SHA 5f9f86bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2188b50 - Browse repository at this point
Copy the full SHA 2188b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for a71f7ad - Browse repository at this point
Copy the full SHA a71f7adView commit details
Commits on Nov 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0f956b5 - Browse repository at this point
Copy the full SHA 0f956b5View commit details -
Move incremental Trace encoding to a-e-r-protobuf
To enable incrmental compilation of traces, we add a patch to the Trace.encode method generated by protobujs to accept and store encoded traces. Occassionally with multiple instances of apollo-engine-reporting that share the same version of the protobuf, the wrapper method gets applied more than once. In order to ensure that the wrapper only gets applied once, we patch the Trace.encode method inside of apollo-engine-protobuf. tsc hangs on the processing the generated protobuf.js files, so the tsconfig.json ignores the generated protobuf file. In order for the typescript index.ts file to compile the generated protobuf.js file is output to the src folder. To ensure the protobuf files are available to the production build, `npm run compile` copies the protobuf file manually from src to dist.
Configuration menu - View commit details
-
Copy full SHA for 844563a - Browse repository at this point
Copy the full SHA 844563aView commit details
Commits on Dec 3, 2018
-
Reexport protobuf import after modification
`export * from './protobuf'` exports the unmodified reference
Configuration menu - View commit details
-
Copy full SHA for a027334 - Browse repository at this point
Copy the full SHA a027334View commit details -
Update comment on Trace.encode to point at a-e-r-p
The override now occurs inside of apollo-engine-reporting-protobuf due to the case of having multiple reporting challenges, so we need to update the comments to help indicate that
Configuration menu - View commit details
-
Copy full SHA for f756174 - Browse repository at this point
Copy the full SHA f756174View commit details -
In order to simplify the generation of this library, we move the change the index.ts file into index.js and remove the typescript build step. Since the type safety is created by the protobufjs generation, this seems acceptable. In general this portion of the code should remain relatively stable, so generating and copying the code with `prepare` remains reasonable.
Configuration menu - View commit details
-
Copy full SHA for 36c46bc - Browse repository at this point
Copy the full SHA 36c46bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b533e45 - Browse repository at this point
Copy the full SHA b533e45View commit details
Commits on Dec 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f45c549 - Browse repository at this point
Copy the full SHA f45c549View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04ba11a - Browse repository at this point
Copy the full SHA 04ba11aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f590d1 - Browse repository at this point
Copy the full SHA 2f590d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05a2e4b - Browse repository at this point
Copy the full SHA 05a2e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 307c4f1 - Browse repository at this point
Copy the full SHA 307c4f1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.