Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set content type to text/html for playground #2026

Merged
merged 4 commits into from
Nov 30, 2018

Conversation

jamiehodge
Copy link
Contributor

@jamiehodge jamiehodge commented Nov 26, 2018

BUGFIX: the playground page is currently being served without a content type

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@jamiehodge: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

jamiehodge added a commit to jamiehodge/apollo-server that referenced this pull request Nov 29, 2018
jamiehodge added a commit to jamiehodge/apollo-server that referenced this pull request Nov 29, 2018
@jamiehodge
Copy link
Contributor Author

There doesn't appear to be an easy way to get the headers from the rp response as-is. Not sure if it's worth it.

@jamiehodge
Copy link
Contributor Author

@abernix it would be great to get this small change in. The playground currently fails to render as HTML in some environments.

@abernix abernix added this to the 2.2.6 milestone Nov 30, 2018
@abernix abernix merged commit bcabbb7 into apollographql:master Nov 30, 2018
@abernix
Copy link
Member

abernix commented Nov 30, 2018

Thanks. No promises I'll get this out in a new release today, but I'll try.

@jamiehodge jamiehodge deleted the patch-1 branch December 3, 2018 10:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants