Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look in event.path first when selecting endpoint for GraphQL Playground on Lambda, and check for null #1527

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Look in event.path first when selecting endpoint for GraphQL Playground on Lambda, and check for null #1527

merged 2 commits into from
Aug 13, 2018

Conversation

stubailo
Copy link
Contributor

See here: https://docs.aws.amazon.com/lambda/latest/dg/eventsources.html#eventsources-api-gateway-request

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo stubailo changed the title Look in event.path first, and check for null Look in event.path first when selecting endpoint for GraphQL Playground on Lambda, and check for null Aug 13, 2018
@jbaxleyiii jbaxleyiii self-requested a review August 13, 2018 19:56
@jbaxleyiii
Copy link
Contributor

@stubailo looks great to me! Thanks for fixing that

@jbaxleyiii jbaxleyiii merged commit 8ca7380 into master Aug 13, 2018
@jbaxleyiii jbaxleyiii deleted the path branch August 13, 2018 19:58
@dependencies dependencies bot mentioned this pull request Aug 15, 2018
Open
@dependencies dependencies bot mentioned this pull request Oct 1, 2018
Open
@danielpatrickdotdev danielpatrickdotdev mentioned this pull request Oct 28, 2020
Closed
This was referenced Apr 27, 2021
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbaxleyiii jbaxleyiii jbaxleyiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stubailo @jbaxleyiii