Throw error in applyMiddleware for vanilla apollo-server #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Listen takes the same arguments as http.Server.listen. | ||
| public async listen(...opts: Array<any>): Promise<ServerInfo> { | ||
| // This class is the easy mode for people who don't create their own express | ||
| // object, so we have to create it. | ||
| const app = express(); | ||
|
|
||
| // provide generous values for the getting started experience | ||
| this.applyMiddleware({ | ||
| super.applyMiddleware({ |
There was a problem hiding this comment.
Why is this calling super?
evans
added a commit
that referenced
this pull request
Jul 13, 2018
evans
added a commit
that referenced
this pull request
Jul 13, 2018
applyMiddleware is not a public api for apollo-server, so it should not be used an direct people to the apollo-server-express integration.
|
Change the commit message to include PR name + description |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyMiddlewareis not a public api forapollo-server, so it should not be used an direct people to the apollo-server-express integration.