Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graphql@16 by fixing dependency on apollo-graphql #5941

Closed
2 tasks
sushantdhiman opened this issue Dec 10, 2021 · 2 comments · Fixed by #5955
Closed
2 tasks

Support graphql@16 by fixing dependency on apollo-graphql #5941

sushantdhiman opened this issue Dec 10, 2021 · 2 comments · Fixed by #5955

Comments

@sushantdhiman
Copy link
Contributor

As per #5605 graphql@16 should already be supported but it doesn't look like this.

[email protected] currently dependent upon [email protected] which still requires graphql@15 or below

npm WARN Could not resolve dependency:
npm WARN peer graphql@"^14.2.1 || ^15.0.0" from [email protected]
npm WARN node_modules/apollo-server-core/node_modules/apollo-graphql
npm WARN   apollo-graphql@"^0.9.0" from [email protected]
npm WARN   node_modules/apollo-server-core

To properly complete support for graphql@16

  • Support graphql@16 for apollo-graphql (I don't know where this repo exists)
  • Release apollo-server-core with fixed version of apollo-graphql
@glasser
Copy link
Member

glasser commented Dec 10, 2021

Good point. The best thing to do here is probably just to inline the small amount of code in apollo-graphql that apollo-server-core and apollo-server-plugin-operation-registry use directly into this repo and drop the dependency rather than do more releases of that package. There's no particularly good reason for "the usage reporting specific signature algorithm" and "the operation registry specific signature algorithm" to live far away from the usage reporter and the operation registry plugin.

@glasser
Copy link
Member

glasser commented Dec 10, 2021

(I will also say that while I do see the problem here, I'm confused as to why others haven't run into this yet... surely you are not the first person trying to combine the release of AS3 that is supposed to support graphql@16 with graphql@16...)

@glasser glasser changed the title Support graphql@16 Support graphql@16 by fixing dependency on apollo-graphql Dec 10, 2021
@glasser glasser added 2021-12 and removed 2021-11 labels Dec 10, 2021
glasser added a commit that referenced this issue Dec 17, 2021
…l@16)

In v3.5 we made AS compatible with the changes in graphql@16, but
apollo-server-core had a dependency on the somewhat inactive
apollo-graphql package which doesn't yet allow graphql@16 in its peer deps.

We should eventually publish a new version of apollo-graphql (eg,
apollo-server-plugin-operation-registry also depends on it) but the
Apollo Server usage reporting plugin is the only consumer of
defaultUsageReportingSignature (and it is not important that the
individual transforms that make it up stay compatible with the building
blocks of other functions like the operation registry signature
function) so inlining seems most natural.

Fixes #5941.
glasser added a commit that referenced this issue Dec 17, 2021
…l@16)

In v3.5 we made AS compatible with the changes in graphql@16, but
apollo-server-core had a dependency on the somewhat inactive
apollo-graphql package which doesn't yet allow graphql@16 in its peer deps.

We should eventually publish a new version of apollo-graphql (eg,
apollo-server-plugin-operation-registry also depends on it) but the
Apollo Server usage reporting plugin is the only consumer of
defaultUsageReportingSignature (and it is not important that the
individual transforms that make it up stay compatible with the building
blocks of other functions like the operation registry signature
function) so inlining seems most natural.

Fixes #5941.
glasser added a commit that referenced this issue Dec 17, 2021
…l@16) (#5955)

In v3.5 we made AS compatible with the changes in graphql@16, but
apollo-server-core had a dependency on the somewhat inactive
apollo-graphql package which doesn't yet allow graphql@16 in its peer deps.

We should eventually publish a new version of apollo-graphql (eg,
apollo-server-plugin-operation-registry also depends on it) but the
Apollo Server usage reporting plugin is the only consumer of
defaultUsageReportingSignature (and it is not important that the
individual transforms that make it up stay compatible with the building
blocks of other functions like the operation registry signature
function) so inlining seems most natural.

Fixes #5941.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants