-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support graphql@16 by fixing dependency on apollo-graphql #5941
Comments
Good point. The best thing to do here is probably just to inline the small amount of code in |
(I will also say that while I do see the problem here, I'm confused as to why others haven't run into this yet... surely you are not the first person trying to combine the release of AS3 that is supposed to support graphql@16 with graphql@16...) |
…l@16) In v3.5 we made AS compatible with the changes in graphql@16, but apollo-server-core had a dependency on the somewhat inactive apollo-graphql package which doesn't yet allow graphql@16 in its peer deps. We should eventually publish a new version of apollo-graphql (eg, apollo-server-plugin-operation-registry also depends on it) but the Apollo Server usage reporting plugin is the only consumer of defaultUsageReportingSignature (and it is not important that the individual transforms that make it up stay compatible with the building blocks of other functions like the operation registry signature function) so inlining seems most natural. Fixes #5941.
…l@16) In v3.5 we made AS compatible with the changes in graphql@16, but apollo-server-core had a dependency on the somewhat inactive apollo-graphql package which doesn't yet allow graphql@16 in its peer deps. We should eventually publish a new version of apollo-graphql (eg, apollo-server-plugin-operation-registry also depends on it) but the Apollo Server usage reporting plugin is the only consumer of defaultUsageReportingSignature (and it is not important that the individual transforms that make it up stay compatible with the building blocks of other functions like the operation registry signature function) so inlining seems most natural. Fixes #5941.
…l@16) (#5955) In v3.5 we made AS compatible with the changes in graphql@16, but apollo-server-core had a dependency on the somewhat inactive apollo-graphql package which doesn't yet allow graphql@16 in its peer deps. We should eventually publish a new version of apollo-graphql (eg, apollo-server-plugin-operation-registry also depends on it) but the Apollo Server usage reporting plugin is the only consumer of defaultUsageReportingSignature (and it is not important that the individual transforms that make it up stay compatible with the building blocks of other functions like the operation registry signature function) so inlining seems most natural. Fixes #5941.
As per #5605 graphql@16 should already be supported but it doesn't look like this.
[email protected]
currently dependent upon[email protected]
which still requiresgraphql@15
or belowTo properly complete support for
graphql@16
graphql@16
forapollo-graphql
(I don't know where this repo exists)apollo-server-core
with fixed version ofapollo-graphql
The text was updated successfully, but these errors were encountered: