willResolveField end hook not guaranteed to be called before end of execution #5372
Assignees
Comments
|
This was caught by our internal |
|
Ideally we would fix this by adding a less hacky way to instrument execution to graphql-js. #4667 is sorta similar/related. |
glasser
added a commit
that referenced
this issue
Mar 5, 2024
Paired with @bbeesley. Updates whenResultIsFinished to call callback also on Promise of Array of Promises. Fixes (partially) #5372 and #4667. The test case we're fixing is `'passes result of Promise of Array of Promises to the callback'`, the other tests test existing behaviour. The existing bug prevented us from dynamically setting cache hints in the reference resolver depending on the result of an asynchronous operation. We discovered the bug within an integration test. If you @glasser have an idea how to add an integration test and would like to add it, that would be amazing! --------- Co-authored-by: David Glasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
willResolveField end hooks (which at least are sync) are called from this special
whenResultIsFinishedon the result of a resolver. But that's in parallel with the processing done on that promise by GraphQL execution. So it's possible that it will be called later than the end of execution.What this rolls up into is that
endTimemight end up missing from some nodes at the time the trace is either pre-encoded or converted to stats, so they will be missing anendTimeon the trace and will not be counted for TypeStats if converted in the usage reporting plugin.The text was updated successfully, but these errors were encountered: