@apollographql/graphql-playground-html generates incorrect links if you pass a falsey version

[silenaker]

1.6.26 has a problem, that is
if you don't want a fixed version number and set version option to "", you will get a wrong url

const apolloServer = new ApolloServer({
  schema,
  context: fastify,
  playground: {
    version: "",
    cdnUrl: "",
    settings: {
      "editor.theme": "light",
    },
  },
});

fastify.register(fastifyStatic, {
  root: path.join(__dirname, "../node_modules/@apollographql/graphql-playground-react/"),
  prefix: "/@apollographql/graphql-playground-react/"
});

will contribute to

<link rel="stylesheet" href="/@apollographql/graphql-playground-reactbuild/static/css/index.css">

I found a workaround for the moment，you must set the version option and set route correctly

const apolloServer = new ApolloServer({
  schema,
  context: fastify,
  playground: {
    version: "1.6.26", // must set version
    cdnUrl: "",
    settings: {
      "editor.theme": "light",
    },
  },
});

fastify.register(fastifyStatic, {
  root: path.join(__dirname, "../node_modules/@apollographql/graphql-playground-react/"),
  prefix: "/@apollographql/[email protected]/", // must use corresponding version
});

1.6.29 has fixed this bug

[glasser]

I'm not sure I follow. I'm looking at https://github.com/graphql/graphql-playground/commits/master/packages/graphql-playground-html and I don't see any commits between 1.6.26 and 1.6.29 that seem relevant here?

[glasser]

Also confused because our fork appears to hardcode that /build in the stylesheet link? https://github.com/apollographql/graphql-playground/blob/e598f561eace3d0cfecc39b08b1abd3a0a207b5e/packages/graphql-playground-html/src/render-playground-page.ts#L78

[glasser]

Ah, hmm, that code on master in our fork does not appear to match what is published to npm.

[glasser]

Ah, gotcha, I should be looking at the apollo branch rather than the master branch. This is custom code in our fork, so I think the issue is less "need to upgrade" and more "need to fix our bug".

[glasser]

As a workaround, if you don't pass version at all then Apollo Server will select a version for you and that version should work, though perhaps it might not be the version you want?

[silenaker]

seems that the auto version selection did not work if i did't pass the version option

[abernix]

@silenaker Note my comment in #4932 (comment). If you can update your transitive dependencies (possibly by forcing use of @apollographql/graphql-playground-html version 1.6.27 via your yarn or package lock files, you may be able to test this, otherwise, we'll get a new version published soon.

[glasser]

I believe this is fixed by #4955

[glasser]

I've published a release with this to version 2.21.1-alpha.0. My plan is to release 2.21.1 on Monday. If you want to test that this fix works before then, try running the prerelease yourself, and provide feedback on #4990