Skip to content

Commit

Permalink
types: Try to avoid the runtime cost of `apollo-engine-reporting-prot…
Browse files Browse the repository at this point in the history
…obuf`.

This is an experiment, but hopefully will resolve the issue noted in:

#2162 (comment)
  • Loading branch information
abernix committed Aug 26, 2019
1 parent 4316f57 commit b5f6452
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/apollo-server-types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {

// This seems like it could live in this package too.
import { KeyValueCache } from 'apollo-server-caching';
import { Trace } from 'apollo-engine-reporting-protobuf';
import { ITrace } from 'apollo-engine-reporting-protobuf/dist/protobuf';

export type ValueOrPromise<T> = T | Promise<T>;
export type WithRequired<T, K extends keyof T> = T & Required<Pick<T, K>>;
Expand Down Expand Up @@ -55,7 +55,7 @@ export interface GraphQLRequestMetrics {
forbiddenOperation?: boolean;
registeredOperation?: boolean;
startHrTime?: [number, number];
queryPlanTrace?: Trace.QueryPlanNode;
queryPlanTrace?: ITrace['queryPlan'];
}

export interface GraphQLRequestContext<TContext = Record<string, any>> {
Expand Down

0 comments on commit b5f6452

Please sign in to comment.