Upgrade @types/aws-lambda, resolving an issue

Renovate tried this (on main) at #4811 but got stuck due to DefinitelyTyped/DefinitelyTyped#50224
apollographql · May 7, 2021 · 540456f · 540456f
1 parent 8382b61
commit 540456f
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 39 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "@josephg/resolvable": "1.0.0",
     "@sinonjs/fake-timers": "^7.0.5",
     "@types/async-retry": "1.4.2",
-    "@types/aws-lambda": "8.10.66",
+    "@types/aws-lambda": "8.10.76",
     "@types/body-parser": "1.19.0",
     "@types/bunyan": "1.8.6",
     "@types/connect": "3.4.34",

diff --git a/packages/apollo-server-lambda/package.json b/packages/apollo-server-lambda/package.json
@@ -27,7 +27,7 @@
   },
   "dependencies": {
     "@apollographql/graphql-playground-html": "1.6.27",
-    "@types/aws-lambda": "^8.10.59",
+    "@types/aws-lambda": "^8.10.76",
     "apollo-server-core": "file:../apollo-server-core",
     "apollo-server-env": "file:../apollo-server-env",
     "apollo-server-types": "file:../apollo-server-types"

diff --git a/packages/apollo-server-lambda/src/ApolloServer.ts b/packages/apollo-server-lambda/src/ApolloServer.ts
@@ -123,7 +123,10 @@ export class ApolloServer<
       event: EventT,
       context: LambdaContext,
     ): Promise<APIGatewayProxyResult> => {
-      const eventHeaders = new Headers(event.headers);
+      // https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50224 changed
+      // the typing of event.headers to be effectively Record<string,
+      // string|undefined> but there should be no actual undefineds as values.
+      const eventHeaders = new Headers(event.headers as Record<string, string>);
 
       // Make a request-specific copy of the CORS headers, based on the server
       // global CORS headers we've set above.