Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): an empty document is a syntax error #918

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix(parser): an empty document is a syntax error #918

merged 2 commits into from
Oct 7, 2024

Conversation

SimonSapin
Copy link
Contributor

In the spec grammar, both Document and ExecutableDocument have a one or more list suffix without an opt suffix so an empty list does not match the grammar.

@SimonSapin SimonSapin merged commit b612469 into main Oct 7, 2024
12 checks passed
@SimonSapin SimonSapin deleted the eof branch October 7, 2024 19:27
@SimonSapin SimonSapin mentioned this pull request Oct 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

@lrlna lrlna Awaiting requested review from lrlna lrlna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSapin @goto-bus-stop