Create EOF token with empty data #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allancalix
commented
Jul 10, 2023
| - [email protected] | ||
| - [email protected] "query" | ||
| - [email protected] " " | ||
| - [email protected] | ||
| - [email protected] "__typename" | ||
| - ERROR@16..19 "EOF" | ||
| - ERROR@16..16 "" |
There was a problem hiding this comment.
Not sure what to make of this here, the OPERATION_DEFINITION is now showing the correct character span (the source is 16 characters long) but I don't know why this error message is empty.
There was a problem hiding this comment.
It's an error token, not an error message, so IMO it's correct like this
goto-bus-stop
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr Make consuming the token stream's data produce an identical string to the original input of the lexer.
I was working on a streaming processor using the streaming lexer and noticed that the
Token::Eofhas"EOF"as a string hard-coded as it's data. This doesn't appear to be used anywhere (though is maybe a breaking change?) and the tests still pass without this.The formatter for
Debugprefixes the location withEOFso the debugging output is not effected. The practical effect of this is that consuming a token stream's data does not produce the same output as the original input.