Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apollo-rs): run cargo fmt check in CI's lint command #338

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

lrlna
Copy link
Member

@lrlna lrlna commented Oct 31, 2022

What do we think? Is this going to be very annoying?

@lrlna lrlna requested a review from goto-bus-stop October 31, 2022 16:49
@lrlna lrlna self-assigned this Oct 31, 2022
@goto-bus-stop
Copy link
Member

I think it'll b e fine as we get the checks on PRs, where its not different from having clippy complain, but easier to fix 🤔

@lrlna
Copy link
Member Author

lrlna commented Nov 1, 2022

ok, i'll leaved this in, if it starts getting annoying, we can always remove

@lrlna lrlna merged commit c51ba55 into main Nov 1, 2022
@lrlna lrlna deleted the ci-cargo-fm branch November 1, 2022 11:02
goto-bus-stop pushed a commit that referenced this pull request Nov 3, 2022
* chore(apollo-rs): run cargo fmt check in CI's lint command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants