feat(apollo-compiler): create diagnostics with source spans #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces diagnostics to
apollo-compiler
. Given SyntaxNode information we have fromapollo-parser
, we are able to store that information in compiler'sValues
and create proper source spans.We are using
miette
to create diagnostics. Graphical display thatmiette
provides is only available withDisplay
. This means diagnostics can be used in myriads of other use cases that might not need the graphical interface (e.g. wasm).(almost) all
values
inapollo-compiler
store a pointer back to the AST which can be accessed withast_node()
getter methods.