Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apollo-parser: ArgumentsDefinition is now correctly parsed #187

Merged
merged 2 commits into from
Mar 3, 2022
Merged

apollo-parser: ArgumentsDefinition is now correctly parsed #187

merged 2 commits into from
Mar 3, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Mar 3, 2022

close #186

@bnjjj bnjjj added bug Something isn't working apollo-parser labels Mar 3, 2022
@bnjjj bnjjj requested a review from lrlna March 3, 2022 15:25
@bnjjj bnjjj self-assigned this Mar 3, 2022
lrlna
lrlna requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result of this change a few tests in the test_data dir will have to be updated. You should be able to do this with env UPDATE_EXPECT=1 cargo test --package apollo-parser.

Otherwise the change looks good!!

@bnjjj bnjjj changed the title apollo-parser: is now correctly parsed apollo-parser: ArgumentsDefinition is now correctly parsed Mar 3, 2022
@bnjjj bnjjj requested a review from lrlna March 3, 2022 16:18
@bnjjj
Copy link
Contributor Author

bnjjj commented Mar 3, 2022

Thanks ! I updated the test data

lrlna
lrlna approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@lrlna lrlna merged commit 2671683 into main Mar 3, 2022
@lrlna lrlna deleted the bnjjj/fix_186 branch March 3, 2022 17:13
lrlna pushed a commit that referenced this pull request Mar 23, 2022
@bnjjj @lrlna
fix(apollo-parser): ArgumentsDefinition is now correctly parsed (#187)
d7b7a9a 
* apollo-parser:  is now correctly parsed

Signed-off-by: Benjamin Coenen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna lrlna approved these changes

Assignees

@bnjjj bnjjj

Labels
apollo-parser bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apollo-parser: ArgumentsDefinition does not seem to be parsed
2 participants
@bnjjj @lrlna