fix(apollo-parser): fix a bad parsing on fragment detected by apollo-smith #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
reviewed
Feb 8, 2022
…smith Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
force-pushed
the
bnj/fix_fragment_parsing
branch
from
7093c37 to
e60ff29
Compare
lrlna
reviewed
Feb 8, 2022
| pet | ||
| ...snackSelection |
There was a problem hiding this comment.
since you're already editing these selection_with_fragment tests, could you also add the other fragment variants?
Suggested change
| ...snackSelection | |
| ...snackSelection | |
| ... on Nap { | |
| cozyLocation | |
| durationOfNap | |
| } | |
| ...snackSelection @deprecated | |
| ... on Nap @provides(duration: "2 hours") { | |
| cozyLocation | |
| } |
There was a problem hiding this comment.
ahhh oops just saw that you merged! i'll just quickly add these in another branch
lrlna
added a commit
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.