Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize peek n #113

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Optimize peek n #113

merged 2 commits into from
Nov 17, 2021

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Nov 17, 2021

Fix #108
related to apollographql/router#100

this avoids collecting the list of tokens in peek_n and peek_data_n. When running the benchmarks locally, I get:

@Geal Geal requested a review from lrlna November 17, 2021 16:38
@lrlna
Copy link
Member

lrlna commented Nov 17, 2021

@Geal could you rebase from main to get the circleci config? I merged it 30 min ago or so.

@Geal
Copy link
Contributor Author

Geal commented Nov 17, 2021

sure

lrlna
lrlna approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! This looks really good to me.

@lrlna lrlna merged commit 6e8e8a8 into main Nov 17, 2021
@lrlna lrlna deleted the optimize_peek_n branch November 17, 2021 16:58
@Geal
Copy link
Contributor Author

Geal commented Nov 17, 2021

awesome, thanks

@cecton cecton mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna lrlna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimising peek_n
2 participants
@Geal @lrlna