Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexer does not create an error for an invalid escaped character #229

Closed
bnjjj opened this issue May 17, 2022 · 0 comments · Fixed by #228
Closed

lexer does not create an error for an invalid escaped character #229

bnjjj opened this issue May 17, 2022 · 0 comments · Fixed by #228
Assignees
@bnjjj
Labels
apollo-parser bug Something isn't working

Comments

@bnjjj
Copy link
Contributor

bnjjj commented May 17, 2022

the parser should return an error because \a is not a valid character https://spec.graphql.org/June2018/#sec-String-Value

Originally posted by @Geal in #228 (comment)
@bnjjj bnjjj self-assigned this May 17, 2022
bnjjj added a commit that referenced this issue May 18, 2022
@bnjjj
fix(lexer): do not accept wrong escaped chars #229
6df9cbb 
Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj mentioned this issue May 18, 2022
Merged
@lrlna lrlna added apollo-parser bug Something isn't working labels May 23, 2022
@lrlna lrlna changed the title the parser should return an error because \a is not a valid character lexer does not create an error for an invalid escaped character May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
apollo-parser bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parser): add a fix for StringValue node when we start with a backslash apollographql/apollo-rs
2 participants
@bnjjj @lrlna