NON_NULL_TYPE node is missing BANG SyntaxKind

[kpeters-cbsi]

Description

This applies to apollo-parser v0.2.0

When a mutation is parsed into a Document doc, doc.toString() does not correctly preserve the "required" state of the variables.

mutation MyMutation($custId: Int!) {
    myMutation(custId: $custId)
}

Steps to reproduce

Execute the following Rust program:

use apollo_parser::Parser;

const MUTATION: &str = r#"mutation MyMutation($custId: Int!) {
    myMutation(custId: $custId)
}"#;


fn main() {
    let parser = Parser::new(MUTATION);
    let ast = parser.parse();
    if ast.errors().len() > 0 {
        dbg!(ast.errors());
        panic!("Parse error");
    } else {
        let doc = ast.document();
        println!("{}", doc.to_string());
    }
}

Expected result

Should produce a semantically identical copy of the response having $custId marked as required.

mutation MyMutation($custId: Int!) {
    myMutation(custId: $custId)
}

Actual result

Produced a copy of the response where $custId was not a required variable.

mutation MyMutation($custId: Int) {
    myMutation(custId: $custId)
}

Environment

• Operating system and version: MacOS Big Sur 11.6
• Shell (bash/zsh/powershell): zsh
• Crate version: 0.2.0

[lrlna]

@kpeters-cbsi thank you so much for submitting this! It seems like we are missing the BANG (!) token in the AST. The node gets recorded as as NON_NULL_TYPE, but it doesn't have the token that actually makes it NON_NULL. This is an easy fix, and I can fix and publish a patch for you tomorrow.

[kpeters-cbsi]

So when will we see a new release incorporating this fix?

[lrlna]

today! I found another issue sort of related to this in #143 which you'll run into as soon as you have more than one variable, for example:

mutation MyMutation($custId: Int!, $b: String ) {
    myMutation(custId: $custId)
}

the to_string() version of the doc is entirely nonsensical:

 mutation MyMutation($custId: , Int!$b:  String) {
    myMutation(custId: $custId)
}

[lrlna]

@kpeters-cbsi you can now install 0.2.1 with the latest fix. Let me know if you run into trouble!