Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue iterator is not final used in nested inner class #934

Merged

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented May 31, 2018

The issue is specific to Java7 and can't be reproduced on Java8. Apparently the iterator declared in for loop on Java7 must be with final keyword if it's going to be used inside the nested inner class.

Closes #932

@sav007 sav007 requested a review from digitalbuddha May 31, 2018 20:58
@CrisCR
Copy link

CrisCR commented Jun 1, 2018

Is there a snapshot available for this fix?

@sav007 sav007 merged commit f24ac63 into apollographql:master Jun 1, 2018
@sav007 sav007 deleted the bug-932/final-for-loop-iterator branch June 1, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants