Add support connection keep alive message (aka heartbeat) #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalbuddha
approved these changes
May 23, 2018
|
Not sure that we need the max timeout, as it's totally up to user to decide, if they want never reconnect than so be it. Otherwise what the max should be 30 sec or 1 hr? The only I think we need to switch off this feature by default, and only enable it if user explicitly provide timeout that |
|
cool all set then |
Add support of heartbeat messages sent by the subscription server. Closes apollographql#895
sav007
force-pushed
the
feature-895/subscription-heartbeat
branch
from
d261bb8
to
4cdcb38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of heartbeat messages sent by the subscription server.
Closes #895