Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription connection parameters as payload of init message #865

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented Apr 3, 2018

Closes #850

Copy link
Contributor

@digitalbuddha digitalbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick then looks good

@@ -40,10 +42,19 @@ public String toJsonString() {

public static final class Init extends OperationClientMessage {
private static final String TYPE = "connection_init";
private final Map<String, Object> connectionParams;

public Init(@Nonnull Map<String, Object> connectionParams) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase method name

@sav007 sav007 merged commit a3e94da into apollographql:master Apr 5, 2018
@sav007 sav007 deleted the feature-850/subscription-connection-params branch April 5, 2018 18:00
@zetaron zetaron mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants