Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkFirstFetcher fix to return network exception if cache fetch fails #725

Merged
merged 1 commit into from
Nov 23, 2017
Merged

NetworkFirstFetcher fix to return network exception if cache fetch fails #725

merged 1 commit into from
Nov 23, 2017

Conversation

drumtoad
Copy link
Contributor

NetworkFirstFetcher javadoc says that in case of cache fetch failure it should rethrow network exception, but it thrown cache exception instead. Reproducible with sample project(with network off and with no cache). So here's fix to pass network exception on cache fetch fail.

@apollo-cla
Copy link

@drumtoad: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@sav007 sav007 merged commit 6133d79 into apollographql:master Nov 23, 2017
@drumtoad drumtoad deleted the bug/network-first-fetcher-wrong-failure-exception branch November 28, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants