Allow mapping scalars to simple generic types #6158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
LGTM.
2 possible improvements:
- Make it a proper parser for Kotlin
type(unlocksdynamic, function types, variance, wildcards, type annotations, etc...)
2. recognize some frequent auto imports (donekotlin.,kotlin.collections.)
| ) | ||
| } else { | ||
| mapOf( | ||
| "Date" to ScalarInfo("java.util.Date"), | ||
| "URL" to ScalarInfo("kotlin.String", ExpressionAdapterInitializer("com.example.UrlAdapter")), | ||
| "ID" to ScalarInfo("kotlin.Long"), | ||
| "String" to ScalarInfo("kotlin.String", ExpressionAdapterInitializer("com.example.MyStringAdapter()")), | ||
| "ListOfString" to ScalarInfo("kotlin.collections.List<kotlin.String?>"), |
There was a problem hiding this comment.
That is quite the mouthful. I guess List<String?> doesn't work here?
There was a problem hiding this comment.
Just tried to make sure, but no, ClassName.bestGuess() expects a fully qualified name. I'll see if I can add a few shortcuts for String, List, etc.
Comment on lines
+26
to
+34
| private fun String.withPackage(): String { | ||
| return if (this in commonKotlinTypes) { | ||
| "kotlin.${this}" | ||
| } else if (this in commonKotlinCollectionsTypes) { | ||
| "kotlin.collections.${this}" | ||
| } else { | ||
| this | ||
| } | ||
| } |
martinbonnin
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6156 and #3243. This is far from perfect but unlocks a few cases.