Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental WebSockets] connectionParams -> connectionPayload #6103

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[experimental WebSockets] connectionParams -> connectionPayload #6103

merged 1 commit into from
Aug 7, 2024

Conversation

martinbonnin
Copy link
Contributor

For symmetry with the current websocket implementation. Also it makes more sense.

@martinbonnin martinbonnin requested a review from BoD as a code owner August 7, 2024 07:29
@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit b4274f8
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66b32271269b74000825cd18

BoD
BoD approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 6684a79 into main Aug 7, 2024
9 checks passed
@martinbonnin martinbonnin deleted the arg-name branch August 7, 2024 09:14
@martinbonnin martinbonnin added this to the 4.0.1 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD