Prepare apollo-testing-support to new MockServer #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workTransport and MapTestNetworkTransport
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
commented
Jun 3, 2024
Comment on lines
+114
to
+129
| class MockServerTest(val mockServer: MockServer, val apolloClient: ApolloClient, val scope: CoroutineScope) | ||
|
|
||
| fun mockServerTest( | ||
| clientBuilder: ApolloClient.Builder.() -> Unit = {}, | ||
| block: suspend MockServerTest.() -> Unit | ||
| ) = runTest(true) { | ||
| MockServer().use { mockServer -> | ||
| ApolloClient.Builder() | ||
| .serverUrl(mockServer.url()) | ||
| .apply(clientBuilder) | ||
| .build() | ||
| .use {apolloClient -> | ||
| MockServerTest(mockServer, apolloClient, this).block() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This code is duplicated a bunch of times. It's a bit sad but it's very trivial code so it shouldn't be too hard to maintain.
BoD
pushed a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
* Make all of apollo-testing-support deprecated except for QueueTestNetworkTransport and MapTestNetworkTransport * remove usage of apollo-testing-support symbols that pull MockServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
MockServerto a separate repo/packageName would make it a breaking change forapollo-testing-support.Instead,
apollo-testing-supportis going to keep using the current (soon to be deprecated)MockServerfor now. But we don't want to pull that in other parts of the repo.This PR tries to contain the blast radius of MockServer. It makes most of
apollo-testing-supportdeprecated:HostFileSystem,Channel.awaitItem(), etc... were meant to be used from our own tests and the plan is to simply remove them.MockServercould be somewhat useful but there are ways to replace relatively easily.