Prepare for Optimistic update store #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce ApolloInterceptor.InterceptorRequest that will hold request data such as: operation, optimistic updates, fetch options. Request will be passed to the interceptor chain to be processed. - ApolloInterceptor.InterceptorRequest has unique identifier to be used later as Record version to build relationship between records in optimistic store and request which made those records from optimistic data. It will allow to build rollback mechanism, remove records from optimistic store by the request identifier / version. - A little refactoring of Record object Next step is introduce OptimisticNormalizedCache (will be based on top of LruNormalizedCache), plus would be nice to consider create generic abstraction of chaining different implementations of normalized caches and have similar logic that we have for LruNormalizedCache with second cache. So if we can't resolve Record from current layer of cache we ask down the chain the next layer and so on.
digitalbuddha
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step is to introduce OptimisticNormalizedCache (will be based on top of LruNormalizedCache), plus would be nice to consider create generic abstraction of chaining different implementations of normalized caches and have similar logic that we have for LruNormalizedCache with second cache. So if we can't resolve Record from current layer of cache we ask down the chain the next layer and so on.