Remove Moshi from cache layer #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update RecordFieldAdapter to use direct json api instead of moshi lib. Final step to rid off Moshi lib from runtime module. Closes apollographql#572
BenSchwab
approved these changes
Jul 22, 2017
|
@sav007 Can we remove it from Apollo completely? |
|
@jaredsburrows we can't as it used internally for our apollo-compiler but it's not used at runtime |
|
@sav007 Ok, thank you so much. That is what I meant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RecordFieldAdapter to use direct json api instead of moshi lib.
Final step to rid off Moshi lib from runtime module.
Closes #572