-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Moshi with generated marshaller for operation json serialization #578
Replace Moshi with generated marshaller for operation json serialization #578
Conversation
Extract JsonWriter from Moshi lib Introduce InputFieldMarshaller and InputFieldWriter to be used in code generation
@sav007 should this be made configurable. I worry that most won't care about the optimization but will care about the additional methods the request parsing generates. |
@digitalbuddha well I see your point but not sure if that won't be a messy to have it both. I fell like we already have too much configs, and it was our initial idea use generation instead of Moshi. |
Sgtm Im a big fan of removing moshi as we don't use it internally.
…On Jul 19, 2017 5:33 PM, "Ivan Savytskyi" ***@***.***> wrote:
@digitalbuddha <https://github.com/digitalbuddha> well I see your point
but not sure if that won't be a messy to have it both. I fell like we
already have too much configs, and it was our initial idea use generation
instead of Moshi.
Plus I feel like we really won't benefit of saving couple methods here.
Maybe we can later optimize it a little bit when such concern raised.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#578 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUX3M52DQ7fL0ZBFLK4K67mVxuIx4kcks5sPnYRgaJpZM4Oc_q7>
.
|
@digitalbuddha I completely agree. @sav007 In this PR, I did not see you remove the dependency from the |
Are you going to remove moshi completely from this repository? It looks like it is still used: https://github.com/apollographql/apollo-android/search?utf8=%E2%9C%93&q=moshi&type=. |
Part of #572
Next step is to remove Moshi from SqlNormalizedCache