Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐘gradle-plugin] configuration cache and lazy properties for schema files #5580

Merged
merged 3 commits into from
Jan 30, 2024
Merged

[🐘gradle-plugin] configuration cache and lazy properties for schema files #5580

merged 3 commits into from
Jan 30, 2024

Conversation

martinbonnin
Copy link
Contributor

Rework the schema wiring to use FileCollections everywhere.

Fixes #5455
Fixes #5221

There is still an issue that FileCollections do not distinguish between "unset" and "empty". See gradle/gradle#21752 so in the event that someone misconfigures their schemaFiles option, it might still fallback to src/main/graphql/**.graphql but oh well...

@martinbonnin martinbonnin changed the title 03 schema configuration cache [gradle-plugin] configuration cache and lazy properties for schema files Jan 29, 2024
@martinbonnin martinbonnin changed the title [gradle-plugin] configuration cache and lazy properties for schema files [🐘gradle-plugin] configuration cache and lazy properties for schema files Jan 29, 2024
@martinbonnin martinbonnin marked this pull request as ready for review January 29, 2024 14:16
@martinbonnin martinbonnin requested a review from a team as a code owner January 29, 2024 16:19
Base automatically changed from 02-bump-gradle to main January 29, 2024 17:10
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 81c3268
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65b7dcadce5c900008222cc4

@martinbonnin martinbonnin mentioned this pull request Jan 30, 2024
Open
@martinbonnin martinbonnin merged commit 50f7e04 into main Jan 30, 2024
9 checks passed
@martinbonnin martinbonnin deleted the 03-schema-configuration-cache branch January 30, 2024 09:59
martinbonnin added a commit that referenced this pull request Feb 5, 2024
@martinbonnin
[🐘gradle-plugin] configuration cache and lazy properties for schema f…
cf37b05 
…iles (#5580)

* add a test for #5455

* Fix configuration cache and schema file auto detection

Closes #5455
Closes #5221

* add a test for #5221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martinbonnin @BoD