Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug server: don't crash when a client has no caches #5479

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Dec 13, 2023

Thanks @rohandhruva for the report!

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 7058dc3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6579fad35faeb60008cd1f8a


api(project(":apollo-ast"))
api(project(":apollo-api"))
implementation(project(":apollo-normalized-cache-api"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one should be necessary (it's api in :apollo-normalized-cache), but I'm getting red inside IJ without it 🤷‍♀️

api(project(":apollo-ast"))
api(project(":apollo-api"))
implementation(project(":apollo-normalized-cache-api"))
implementation(project(":apollo-ast"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have been api.

api(project(":apollo-api"))
implementation(project(":apollo-normalized-cache-api"))
implementation(project(":apollo-ast"))
api(project(":apollo-runtime"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApolloClient is in apollo-runtime, not apollo-api

@BoD BoD merged commit 1f6fcc0 into main Dec 14, 2023
9 checks passed
@BoD BoD deleted the apollo-debug-server-fix-no-caches branch December 14, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants