-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apollo-tooling] bump bootstraped version of Apollo to 4.0.0-beta.3
#5452
Conversation
✅ Deploy Preview for apollo-android-docs canceled.
|
ff95506
to
ae2c464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
libraries/apollo-tooling/src/main/kotlin/com/apollographql/apollo3/tooling/SchemaUploader.kt
Outdated
Show resolved
Hide resolved
|
4.0.0-beta.3
I removed the Gradle test from this PR as the |
libraries/apollo-tooling/src/main/kotlin/com/apollographql/apollo3/tooling/SchemaUploader.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
...aries/apollo-tooling/src/main/kotlin/com/apollographql/apollo3/tooling/RegisterOperations.kt
Outdated
Show resolved
Hide resolved
Made another pass at it. Looks like we can factor the error handling. See |
libraries/apollo-tooling/src/main/kotlin/com/apollographql/apollo3/tooling/Telemetry.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-tooling/src/main/kotlin/com/apollographql/apollo3/tooling/FieldInsights.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made another pass at it. Looks like we can factor the error handling. See ApolloResponse.toException (source). Let me know what you think
Yes looks good 👍
I merged this PR so it doesn't become stale and we can move forward with other PRs. Reminder to ourselves to re-test again using the integration test since there's been a few changes since your last tests. |
Eat our own
@catch
food.