Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First drop for data builders #4321

Merged
merged 8 commits into from
Aug 8, 2022
Merged

First drop for data builders #4321

merged 8 commits into from
Aug 8, 2022

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Aug 5, 2022

Simple use case is in tests:

    val data = GetStuffQuery.Data {
      nullableInt = null
      nonNullableInt = 42

      this["alias"] = 50
    }

    assertEquals(null, data.nullableInt)
    assertEquals(42, data.nonNullableInt)
    assertEquals(50, data.alias)

Still needed:

  • custom scalars support
  • java codegen
  • default values
  • strict mode
  • use in our own tests
  • (maybe) cleanup the IrType2 stuff

See #4016

@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit ce23c65
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/62ed3734ae07b4000966fe39

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@martinbonnin martinbonnin merged commit 6fb6535 into main Aug 8, 2022
@martinbonnin martinbonnin deleted the data-builders branch August 8, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants