Native: assume New Memory Manager #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/http/Http.kt
Show resolved
Hide resolved
...incubating/src/appleMain/kotlin/com/apollographql/apollo3/cache/normalized/internal/Guard.kt
Outdated
Show resolved
Hide resolved
apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/internal/dispatchers.kt
Outdated
Show resolved
Hide resolved
apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/internal/dispatchers.kt
Outdated
Show resolved
Hide resolved
...untime/src/appleMain/kotlin/com/apollographql/apollo3/network/http/NSURLSessionHttpEngine.kt
Show resolved
Hide resolved
apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/internal/multipart.kt
Outdated
Show resolved
Hide resolved
...runtime/src/commonMain/kotlin/com/apollographql/apollo3/network/http/HttpNetworkTransport.kt
Show resolved
Hide resolved
apollo-testing-support/src/commonMain/kotlin/com/apollographql/apollo3/testing/runTest.kt
Show resolved
Hide resolved
apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/internal/dispatchers.kt
Outdated
Show resolved
Hide resolved
martinbonnin
requested changes
Jul 22, 2022
apollo-mpp-utils/src/appleMain/kotlin/com/apollographql/apollo3/mpp/utils.kt
Show resolved
Hide resolved
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/http/Http.kt
Outdated
Show resolved
Hide resolved
|
Something that just came to mind, we'll need to update https://github.com/apollographql/apollo-kotlin/blob/f890e3408d61acaa60aa5f6f2a3da93256bdf1ce/design-docs/Threading.md. Let me know if you want to do it. Or I can too. |
|
@martinbonnin I've just applied minor tweaks to Threading.md to remove / update obviously no longer correct or relevant bits. but it may benefit from a bigger revamp :) Don't hesitate to make more changes if you feel inspired! |
martinbonnin
approved these changes
Jul 28, 2022
…t for background dispatchers - Remove suspendAndResumeOnMain, replaced with suspendCancellableCoroutine - Remove assertMainThreadOnNative
…/internal/multipart.kt Co-authored-by: Martin Bonnin <[email protected]>
…freeze, isFrozen, as no-ops to avoid a breaking change
…tore" This reverts commit 1de5b75.
…/http/Http.kt Co-authored-by: Martin Bonnin <[email protected]>
…guring the new MM
BoD
force-pushed
the
new-memory-manager-2
branch
from
a4dfcfc
to
867522f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume running under the New Memory Manager (aka New Memory Model).
Related to #4100
newFixedThreadPoolContext/newSingleThreadContextfreezeand relatedrunTestas deprecated