Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @typePolicy directive on interfaces and unions #4131

Merged
merged 2 commits into from
May 25, 2022
Merged

Allow @typePolicy directive on interfaces and unions #4131

merged 2 commits into from
May 25, 2022

Commits on May 23, 2022

  1. Allow @typePolicy directive on interfaces and unions 

    Closes apollographql#3356
This fixes a couple of things:
It changes the @typePolicy directive definition in apollo.graphqls to allow it to be used on interfaces and unions
And in order for it to work on interfaces, GQLInterfaceTypeExtension has been extended to store the directives.
It then validates that an object that implements an interface(s) doesn't override any key fields.
This required moving the keyFields() logic out of Schema.kt and into gqltypedefinition.kt
    @lukel97
    lukel97 committed May 23, 2022
    Configuration menu
    Copy the full SHA
    10335ad View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. cache the keyfields in the schema

    @martinbonnin
    martinbonnin committed May 24, 2022
    Configuration menu
    Copy the full SHA
    7de9b02 View commit details
    Browse the repository at this point in the history