Use a constant for JvmOverloads to avoid a crash due to relocation

[BoD]

A fix for #4004.

There were also a few other instances or classes used directly, which didn't seem to cause trouble, but also fixed here for consistency.

[netlify]

✅ Deploy Preview for apollo-android-docs canceled.

Name	Link
🔨 Latest commit	d95ae6f
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-android-docs/deploys/6253fab496faa90008536faf

[martinbonnin]

👍 I think the JDK classes (like java.lang.Override and java.lang.String) are not relocated because they're not part of the fat jar so that'd explain why this has worked so far.

Doesn't hurt to not use them reflectively though 👍

[martinbonnin]

CI fails with

fullstack/LaunchDetailsQuery.kt: (22, 19):  Declaration annotated with '@OptionalExpectation' can only be used in common module sources

[BoD]

Nothing's ever easy is it? 😅
I'm guessing this is due to the specific wiring in integration-tests to have both Java and Kotlin codegens?

I moved the test to a specific submodule instead - JVM only but also tried locally on a MP one which also didn't have the issue.

[martinbonnin]

I'm guessing this is due to the specific wiring in integration-tests to have both Java and Kotlin codegens?

How would that be an issue? Java codegen is not impacted and Kotlin should compile in all cases?

[BoD]

How would that be an issue? Java codegen is not impacted and Kotlin should compile in all cases?

That was kind of a wild guess, but in fact I just noticed it's compileTestKotlinJs that's failing 🤔. Will investigate more.

[BoD]

I can repro Declaration annotated with '@OptionalExpectation' can only be used in common module sources by setting this on my test project:

  outputDirConnection {
    connectToKotlinSourceSet("jsTest")
    connectToKotlinSourceSet("jvmTest")
    connectToKotlinSourceSet("appleTest")
  }

but to be honest I'm still bewildered

[martinbonnin]

👍