Creating a copy() funtion for the ApolloRequest #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a new Operation which consumes the exact same values as an existing request and returns the result. Useful for when we want to intercept and relay the ApolloRequest through various stages of the netowrk request.
AdamMTGreenberg
requested review from
sav007,
martinbonnin and
BoD
as code owners
|
@AdamMTGreenberg: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
AdamMTGreenberg
changed the title
martinbonnin
reviewed
Apr 3, 2022
| return Builder(operation) | ||
| fun newBuilder(): Builder<D> = duplicate(Builder(operation)) | ||
|
|
||
| fun copy(operation: Operation<D>): ApolloRequest<D> = duplicate(Builder(operation)).build() |
There was a problem hiding this comment.
Thanks for sending this ! I understand the use case but I'd like to avoid the "copy" vocabulary here because it hints heavily at data classes which are not really used here.
Instead, maybe use newBuilder(operation: Operation<E>)? It also makes it more discoverable?
fun newBuilder(): Builder<D> {
return newBuilder(operation)
}
fun <E: Operation.Data> newBuilder(operation: Operation<E>): Builder<E> {
|
Hi 👋 . I took the liberty of pushing |
BoD
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Creating a copy() constructor for the ApolloRequest to allow setting a new Operation which consumes the exact same values as an existing request and returns the result. Useful for when we want to intercept and relay the ApolloRequest through various stages of the netowrk request. * add newBuilder(operation) Co-authored-by: Martin Bonnin <[email protected]> (cherry picked from commit c8d3fb7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: to allow setting a new
Operationwhich consumes the exact same values as an existing request and returns the result. Useful for when we want to intercept and relay theApolloRequestthrough various stages of the network request.There are various points in the API where one may want to wrap or proxy calls in the chain and without access to the
Operation, we cannot. Thiscopyfunction would allow the consumer to be sure that all values (beside the UUID) would be copied over, both now and in the future.