Defer: take @defer cases into account with normalized cache #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
commented
Apr 1, 2022
...monMain/kotlin/com/apollographql/apollo3/cache/normalized/internal/ApolloCacheInterceptor.kt
Show resolved
Hide resolved
BoD
commented
Apr 1, 2022
...monMain/kotlin/com/apollographql/apollo3/cache/normalized/internal/ApolloCacheInterceptor.kt
Show resolved
Hide resolved
martinbonnin
reviewed
Apr 4, 2022
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/AdapterContext.kt
Show resolved
Hide resolved
martinbonnin
reviewed
Apr 4, 2022
| @@ -72,26 +74,25 @@ val CacheFirstInterceptor = object : ApolloInterceptor { | |||
| } else { | |||
| throw it | |||
| } | |||
| }.singleOrNull() | |||
| }.map { response -> | |||
There was a problem hiding this comment.
This breaks the contract that CacheFirst emits only once. I guess there's no real way around this but the doc needs to be updated
martinbonnin
reviewed
Apr 4, 2022
...monMain/kotlin/com/apollographql/apollo3/cache/normalized/internal/ApolloCacheInterceptor.kt
Outdated
Show resolved
Hide resolved
martinbonnin
reviewed
Apr 4, 2022
.../src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/FetchPolicyInterceptors.kt
Show resolved
Hide resolved
BoD
force-pushed
the
defer-normalized-cache-interceptor-updates
branch
from
e2caa01 to
5ae4d7d
Compare
| """{"data":{"computers":[{"__typename":"Computer","id":"Computer1"}]},"hasNext":true}""", | ||
| """{"data":{"cpu":"386","year":1993,"screen":{"__typename":"Screen","resolution":"640x480"}},"path":["computers",0],"hasNext":true}""", | ||
| """{"data":{"isColor":false},"path":["computers",0,"screen"],"hasNext":false,"label":"a"}""", | ||
| ) |
There was a problem hiding this comment.
(Dog) Food for thought: looks like we could use test builders to simplify those tests
martinbonnin
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With defer, multiple elements can be emitted in Flows returned by the network, which prompted a few adaptations in the normalized cache interceptors.
Also, always read deferred fragments in the adapter when used to parse cached values.