Refactor package structure #368
Conversation
sav007
requested review from
brianPlummer,
BenSchwab,
digitalbuddha and
marwanad
gradle.properties
Outdated
| @@ -1,13 +1,13 @@ | |||
| GROUP=com.apollographql.android | |||
There was a problem hiding this comment.
We're good to change that to com.apollographql according to https://issues.sonatype.org/browse/OSSRH-27585
| @@ -25,6 +25,7 @@ class ApolloPlugin implements Plugin<Project> { | |||
| private static final String NODE_VERSION = "6.7.0" | |||
| public static final String TASK_GROUP = "apollo" | |||
| private static final String APOLLO_DEP_GROUP = "com.apollographql.android" | |||
| //TODO change this to apollo-runtime when it will be published | |||
There was a problem hiding this comment.
issue pls
I think the better approach would be to comment out the line that adds the runtime dependency and disable the plugin tests.
It's better to not package that artifact at all instead of packaging the wrong one.
apollo-rxsupport/gradle.properties
Outdated
| @@ -1,4 +1,4 @@ | |||
| POM_ARTIFACT_ID=RxSupport | |||
| POM_ARTIFACT_ID=apollo-rx-support | |||
| POM_NAME=ApolloStack RxSupport | |||
There was a problem hiding this comment.
unrelated but Apollo GraphQL RxSupport?
Same for other gradle.properties
| @@ -5,8 +5,4 @@ | |||
| /** TODO **/ | |||
| public interface ResponseReader { | |||
| <T> T read(Field field) throws IOException; | |||
|
|
|||
| interface ValueHandler { | |||
There was a problem hiding this comment.
what happened to interface?
There was a problem hiding this comment.
It's not used, legacy (forgot to remove when we refactored response readers)
|
Lgtm |
| @@ -14,7 +14,7 @@ jdk: | |||
| - oraclejdk8 | |||
|
|
|||
| script: | |||
| - ./gradlew clean build connectedCheck -x checkstyleTest --stacktrace | |||
| - ./gradlew clean build connectedCheck -x checkstyleTest -x :apollo-integration:compileDebugUnitTestJavaWithJavac -x :apollo-integration:compileReleaseUnitTestJavaWithJavac --stacktrace | |||
There was a problem hiding this comment.
Can do -Dapollographql.skipRuntimeDep=true -x apollo-gradle-plugin:test faster than commenting out next time 😀
Closes #250
New package structure: