Add parsing of non-standard Error fields #3485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed GitHub's API returns Errors that have a non standard
type
field.Looking at the spec, these are discouraged but still allowed - so I thought it could be useful to surface them.
In v2 these would come up in the
extensions
field - but I opted to add a specific field instead, to avoid potential clashes in the (improbable) event where fields with the same name appear at the top level and inextensions
.