Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing of non-standard Error fields #3485

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Nov 2, 2021

I noticed GitHub's API returns Errors that have a non standard type field.

Looking at the spec, these are discouraged but still allowed - so I thought it could be useful to surface them.

In v2 these would come up in the extensions field - but I opted to add a specific field instead, to avoid potential clashes in the (improbable) event where fields with the same name appear at the top level and in extensions.

@BoD
Copy link
Contributor Author

BoD commented Nov 2, 2021

Note: also opened a ticket for GitHub about this.

@BoD BoD merged commit 0a78e9e into dev-3.x Nov 2, 2021
@BoD BoD deleted the non-standard-fields-in-error branch November 2, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants