New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "compat" v2 CustomTypeAdapter to v3 Adapter API #3482

Merged

BoD merged 5 commits into dev-3.x from compat-v2-custom-type-adapter-to-v3-adapter

Nov 2, 2021

Contributor

BoD commented Nov 2, 2021

This is part of #3410

duplicate CustomTypeValue and CustomTypeAdapter from v2 👉 users should be able to use them by updating imports
add a Version2CustomTypeAdapterToAdapter to wrap existing CustomTypeAdapter and expose them as v3 Adapter
add addCustomTypeAdapter on ApolloClient.Builder (and on CustomScalarAdapters) that uses Version2CustomTypeAdapterToAdapter under the hood.


          Add a "compat" v2 CustomTypeAdapter to v3 Adapter API

815668b

BoD added 🚗 Runtime size/medium labels

BoD requested review from martinbonnin, sav007 and tasomaniac as code owners

November 2, 2021 07:35


          Update API dump

533d946

martinbonnin reviewed

View reviewed changes

apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Adapter.kt Show resolved Hide resolved

martinbonnin reviewed

View reviewed changes

...pi/src/commonMain/kotlin/com/apollographql/apollo3/api/Version2CustomTypeAdapterToAdapter.kt Outdated Show resolved Hide resolved

martinbonnin reviewed

View reviewed changes

...pi/src/commonMain/kotlin/com/apollographql/apollo3/api/Version2CustomTypeAdapterToAdapter.kt Outdated Show resolved Hide resolved

martinbonnin reviewed

View reviewed changes

tests/integration-tests/src/commonTest/kotlin/test/ScalarAdapterTest.kt Show resolved Hide resolved

martinbonnin reviewed

View reviewed changes

...pi/src/commonMain/kotlin/com/apollographql/apollo3/api/Version2CustomTypeAdapterToAdapter.kt Outdated Show resolved Hide resolved


          fix Kdoc

martinbonnin reviewed

View reviewed changes

...pi/src/commonMain/kotlin/com/apollographql/apollo3/api/Version2CustomTypeAdapterToAdapter.kt Outdated Show resolved Hide resolved


          Move Version2CustomTypeAdapterToAdapter to internal package, and add …

f7679a2

…a requires optin `ApolloInternal` annotation on it

martinbonnin approved these changes

View reviewed changes


          update apiDump

3c99515

BoD merged commit 576a32c into dev-3.x

BoD deleted the compat-v2-custom-type-adapter-to-v3-adapter branch

November 2, 2021 15:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels